suneet-s commented on pull request #10027: URL: https://github.com/apache/druid/pull/10027#issuecomment-647686948
@chenyuzhi459 I skimmed the tests. It looks like the processing module tests pass the code coverage now with your new tests. ``` Diff coverage statistics: ------------------------------------------------------------------------------ | lines | branches | functions | path ------------------------------------------------------------------------------ | 66% (4/6) | 100% (0/0) | 77% (7/9) | org/apache/druid/query/GroupByMergedQueryRunner.java | 87% (7/8) | 100% (0/0) | 83% (5/6) | org/apache/druid/query/ChainedExecutionQueryRunner.java | 50% (3/6) | 100% (0/0) | 100% (4/4) | org/apache/druid/query/groupby/epinephelinae/ConcurrentGrouper.java | 71% (5/7) | 100% (0/0) | 100% (7/7) | org/apache/druid/query/groupby/epinephelinae/GroupByMergingQueryRunnerV2.java ------------------------------------------------------------------------------ ``` however, it looks like there is a test failure in `ChainedExecutionQueryRunnerTest#testQueryTimeout` ``` testQueryTimeout(org.apache.druid.query.ChainedExecutionQueryRunnerTest) Time elapsed: 60.018 s <<< ERROR! org.junit.runners.model.TestTimedOutException: test timed out after 60000 milliseconds ``` The processing tests are failing on test coverage. I haven't looked closely at how the tests are setup in this PR to validate whether or not the lack of coverage that it's flagging is legitimate ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
