jon-wei commented on pull request #10059: URL: https://github.com/apache/druid/pull/10059#issuecomment-648464185
For the test coverage failures: - I think `isServiceExceptionRecoverable` has enough coverage - For the change in `getSequenceNumber`, it looks like we don't have any existing unit tests that cover the case where the record supplier throws an exception there, so it's up to you if you want to address that, I'm fine with merging this without, I can look into adding one later. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
