clintropolis opened a new pull request #10076:
URL: https://github.com/apache/druid/pull/10076
### Description
#9934 but for `ParallelMergeCombiningSequence`. Also spotted a place where
we weren't closing a non-exploding `BatchedResultCursor` so fixes more leaks
than I was anticipating :metal:.
I might be abusing `ExplodingSequence` added in #9934 in my added tests...
but I needed an interface for checking if my Sequence yielders were cleaning up
after themselves, so.. it served my purposes.
<hr>
This PR has:
- [x] been self-reviewed.
- [x] using the [concurrency
checklist](https://github.com/apache/druid/blob/master/dev/code-review/concurrency.md)
(Remove this item if the PR doesn't have any relation to concurrency.)
- [x] added comments explaining the "why" and the intent of the code
wherever would not be obvious for an unfamiliar reader.
- [x] added unit tests or modified existing tests to cover new code paths,
ensuring the threshold for [code
coverage](https://github.com/apache/druid/blob/master/dev/code-review/code-coverage.md)
is met.
- [ ] added integration tests.
- [ ] been tested in a test Druid cluster.
<hr>
##### Key changed/added classes in this PR
* `ParallelMergeCombiningSequence`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
