maytasm commented on a change in pull request #10088:
URL: https://github.com/apache/druid/pull/10088#discussion_r447207710
##########
File path:
extensions-core/datasketches/src/main/java/org/apache/druid/query/aggregation/datasketches/quantiles/DoublesSketchComplexMetricSerde.java
##########
@@ -77,7 +78,7 @@ public Object extractValue(final InputRow inputRow, final
String metricName)
// This corresponds to "A" in base64, so it is not a digit
if (objectString.isEmpty()) {
return DoublesSketchOperations.EMPTY_SKETCH;
- } else if (Character.isDigit(objectString.charAt(0))) {
+ } else if (NumberUtils.isParsable(objectString)) {
Review comment:
Sounds good to me.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
