gianm commented on a change in pull request #10089:
URL: https://github.com/apache/druid/pull/10089#discussion_r447234160
##########
File path:
indexing-service/src/main/java/org/apache/druid/indexing/common/task/batch/parallel/PartialDimensionDistributionTask.java
##########
@@ -223,17 +224,19 @@ public TaskStatus runTask(TaskToolbox toolbox) throws
Exception
try (
CloseableIterator<InputRow> inputRowIterator =
inputSourceReader.read();
- HandlingInputRowIterator iterator = new
RangePartitionIndexTaskInputRowIteratorBuilder(partitionDimension, SKIP_NULL)
- .delegate(inputRowIterator)
- .granularitySpec(granularitySpec)
- .nullRowRunnable(IndexTaskInputRowIteratorBuilder.NOOP_RUNNABLE)
-
.absentBucketIntervalConsumer(IndexTaskInputRowIteratorBuilder.NOOP_CONSUMER)
- .build()
+ HandlingInputRowIterator iterator =
+ new
RangePartitionIndexTaskInputRowIteratorBuilder(partitionDimension, SKIP_NULL)
+ .delegate(inputRowIterator)
+ .granularitySpec(granularitySpec)
+
.nullRowRunnable(IndexTaskInputRowIteratorBuilder.NOOP_RUNNABLE)
+
.absentBucketIntervalConsumer(IndexTaskInputRowIteratorBuilder.NOOP_CONSUMER)
+ .build()
) {
Map<Interval, StringDistribution> distribution = determineDistribution(
iterator,
granularitySpec,
partitionDimension,
+ dataSchema.getDimensionsSpec().getDimensionNames(),
Review comment:
Maybe use `Rows.toGroupKey`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
