gianm commented on pull request #10098:
URL: https://github.com/apache/druid/pull/10098#issuecomment-653109512
It looks like CI passed except for code coverage. Here is the report. It's
all guice stuff that should be tested by the integration tests. Do people mind
if I add suppressions for these?
```
Diff coverage statistics:
------------------------------------------------------------------------------
| lines | branches | functions | path
------------------------------------------------------------------------------
| 100% (2/2) | 100% (0/0) | 100% (1/1) |
org/apache/druid/server/initialization/jetty/JettyServerModule.java
| 0% (0/1) | 100% (0/0) | 100% (0/0) |
org/apache/druid/server/initialization/jetty/CliIndexerServerModule.java
| 0% (0/1) | 100% (0/0) | 100% (1/1) |
org/apache/druid/server/initialization/jetty/ChatHandlerServerModule.java
| 0% (0/11) | 0% (0/2) | 60% (3/5) |
org/apache/druid/guice/http/JettyHttpClientModule.java
| 72% (8/11) | 0% (0/2) | 33% (2/6) |
org/apache/druid/guice/http/HttpClientModule.java
| 100% (1/1) | 100% (0/0) | 50% (1/2) |
org/apache/druid/guice/http/AbstractHttpClientProvider.java
------------------------------------------------------------------------------
Total diff coverage:
- lines: 40% (11/27)
- branches: 0% (0/4)
- functions: 53% (8/15)
ERROR: Insufficient line coverage of 40% (11/27). Required 50%.
ERROR: Insufficient branch coverage of 0% (0/4). Required 50%.
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
