gianm commented on a change in pull request #10125:
URL: https://github.com/apache/druid/pull/10125#discussion_r449305674
##########
File path:
server/src/main/java/org/apache/druid/client/CachingClusteredClient.java
##########
@@ -401,11 +407,16 @@ private ClusterQueryResult(Sequence<T> sequence, int
numQueryServers)
}
}
- private Set<SegmentServerSelector>
computeSegmentsToQuery(TimelineLookup<String, ServerSelector> timeline)
+ private Set<SegmentServerSelector> computeSegmentsToQuery(
+ TimelineLookup<String, ServerSelector> timeline,
+ boolean specificSegments
+ )
{
+ final java.util.function.Function<Interval,
List<TimelineObjectHolder<String, ServerSelector>>> lookupFn
+ = specificSegments ? timeline::lookupWithIncompletePartitions :
timeline::lookup;
final List<TimelineObjectHolder<String, ServerSelector>> serversLookup =
toolChest.filterSegments(
query,
- intervals.stream().flatMap(i ->
timeline.lookup(i).stream()).collect(Collectors.toList())
+ intervals.stream().flatMap(i ->
lookupFn.apply(i).stream()).collect(Collectors.toList())
Review comment:
> It does truncate the interval, but the query server can handle it. The
query runner for specific segments in `ServerManager` or `AppenderatorImpl`
uses `TimelineLookup.findEntry()` to find the `PartitionHolder` containing the
segments to query. In this `findEntry()`, an entry matches if its interval
contains the given interval.
This isn't what I'm worried about — I'm worried that the SegmentDescriptor
with the shorter interval might not get properly retained in the retry. Will
it? If so, I think it's ok, if a bit sketchy. It would be good to have tests
for it since it's so sketchy.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
