jihoonson edited a comment on pull request #10093: URL: https://github.com/apache/druid/pull/10093#issuecomment-655024790
> @jihoonson: I can add a check for limitPushDown when generating cache key. > But wouldn't it be better for the underlying layers to not worry about whether limitSpec was pushed or not every time ? > The broker logic if it decides to not push down the limit, shouldn't it send a query with a null limitSpec to the underlying layers ? Or is there any reason for the broker to still push down limit spec ? @nishantmonu51 ah, I'm not sure exactly why the broker always sends the limitSpec, guessing it's for simplicity. Sending limitSpec only when pushing down limitSpec seems reasonable, although I don't mind much with the current implementation. I guess it's up to you. I can review the follow-up PR if you are going to do it. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
