jihoonson commented on a change in pull request #10144:
URL: https://github.com/apache/druid/pull/10144#discussion_r451257282
##########
File path: services/src/main/java/org/apache/druid/cli/CliBroker.java
##########
@@ -102,6 +103,12 @@ public CliBroker()
binder.bindConstant().annotatedWith(Names.named("tlsServicePort")).to(8282);
binder.bindConstant().annotatedWith(PruneLoadSpec.class).to(true);
binder.bindConstant().annotatedWith(PruneLastCompactionState.class).to(true);
+ binder.bindConstant()
Review comment:
Ah, there was only one constant to bind at first
(`shouldFailOnTruncatedResponseContext`), and so I just added a constant
binding. Later, to make the test coverage check happier, I added another
constant `maxResponseContextHeaderSize` and just copy-pasted existing code 😅.
Changed to directly bind the context class.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
