nishantmonu51 commented on pull request #10129: URL: https://github.com/apache/druid/pull/10129#issuecomment-657565953
@kroeders : Thanks for the PR. The new rule simplifies rule management for clusters having many datasources, however, I believe the new concept of implicitRule can be confusing for many and opens up possibilities of unexpected behaviours. 1. This introduces dependency on the datasources which is not implied, e.g. If you add an import rule from Datasource A to Datasource B, it might be confusing for the rule change on A to affect B. 2. If someone drops the datasource A, the effect is not clear, from the current proposal it seems it will continue to apply the same rules to other datasources, this will lead to a case there will not be any way to change the dependent rules easily from the console. Instead of defining an import rule, How does adding support for **RuleGroups** seem to you ? The thought being _RuleGroups are named and simply defines a list of Ordered Rules can be applied to multiple datasources_. Implementation wise it would be similar and the rules will be expanded at runtime. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
