clintropolis commented on a change in pull request #10169:
URL: https://github.com/apache/druid/pull/10169#discussion_r454067462
##########
File path:
server/src/test/java/org/apache/druid/server/initialization/JettyTest.java
##########
@@ -511,13 +511,13 @@ private void
waitForJettyServerModuleActiveConnectionsZero(JettyServerModule jsm
{
// it can take a bit to close the connection, so maybe sleep for a while
and hope it closes
final int sleepTimeMills = 10;
- final int totalSleeps = 10_000 / sleepTimeMills;
+ final int totalSleeps = 15_000 / sleepTimeMills;
int count = 0;
while (jsm.getActiveConnections() > 0 && count++ < totalSleeps) {
Thread.sleep(sleepTimeMills);
}
if (jsm.getActiveConnections() > 0) {
- throw new RuntimeException("Connections greater than 0");
+ throw new RuntimeException("Connections greater than 0.
activeConnections=" + jsm.getActiveConnections() + " port=" + port);
Review comment:
nit: could use
```
throw new RE("Connections greater than 0. activeConnections=%s
port=%s", jsm.getActiveConnections(), port);
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
