jihoonson commented on pull request #9987:
URL: https://github.com/apache/druid/pull/9987#issuecomment-662610869


   @richardstartin thanks for updating the PR 🙂 . The latest version is 0.9.1. 
Is there a reason to use 0.9.0 instead of it?
   
   > The new intersection algorithm is faster and allocates less memory in a 
benchmark adapted from druid's benchmarks, but it might be worth testing it out 
on a cluster before accepting the change.
   
   Could you share your benchmark result if possible? It would be nice if you 
can contribute the benchmark code as well, but I don't think it's necessary. 
For cluster testing, do you think that the testing result should be a blocker 
to merge this PR? I see several performance-wise improvements in the commit 
history. Since the bitmap is used to query each segment in Druid, it seems 
enough to me to run simple benchmarks to see the performance of bitmap itself.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to