vogievetsky opened a new pull request #10226:
URL: https://github.com/apache/druid/pull/10226


   This PR materializes a lot of informal feedback that I heard about the rule 
editor UI
   
   
![image](https://user-images.githubusercontent.com/177816/88987124-cd9a1080-d289-11ea-82ea-56b0b4e44d57.png)
   
   Specifically:
   
   - Add suggestions to period dropdown
   - Add basic validation to period dropdown
   - Show the cluster default rules for context
   - Add `...` item to edit the default retention
   - Improve types but replacing `any`s with proper types
   - Expanded testing
   - Remove dead classes, tidy CSS
   
   This PR has:
   - [x] been self-reviewed.
   - [x] added comments explaining the "why" and the intent of the code 
wherever would not be obvious for an unfamiliar reader.
   - [x] added unit tests or modified existing tests to cover new code paths
   - [x] been tested in a test Druid cluster.
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to