FrankChen021 opened a new pull request #10240: URL: https://github.com/apache/druid/pull/10240
<!-- Thanks for trying to help us make Apache Druid be the best it can be! Please fill out as much of the following information as is possible (where relevant, and remove it when irrelevant) to help make the intention and scope of this PR clear in order to ease review. --> ### Description This PR resolves #10192 . The orignal redis cache extension is designed for standalone redis only, and does not support a couple of redis features which are widely used in production. So This PR updates the redis cache extension to: 1. add support for redis cluster 2. allow users to customize which database of a redis they want to use through new property `database` 3. add support for password protected redis servers through new property `password` 4. allow period style configuration for the existing `expiration` and `timeout` properties ### Key changes 1. orignal `RedisCache` is splitted into `AbstractRedisCache` and `RedisStandaloneCache`, the first provides a way to share common code between standalone and cluster mode redis servers 2. `RedisCacheConfig` is updated to support new properties 3. `RedisClusterCache` which inherits from `AbstractRedisCache` is added to interact with redis clusters <hr> This PR has: - [X] been self-reviewed. - [X] added documentation for new or modified features or behaviors. - [X] added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader. - [X] added unit tests or modified existing tests to cover new code paths, ensuring the threshold for [code coverage](https://github.com/apache/druid/blob/master/dev/code-review/code-coverage.md) is met. - [X] been tested in a test Druid cluster. <!-- Check the items by putting "x" in the brackets for the done things. Not all of these items apply to every PR. Remove the items which are not done or not relevant to the PR. None of the items from the checklist above are strictly necessary, but it would be very helpful if you at least self-review the PR. --> ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
