suneet-s commented on a change in pull request #10191:
URL: https://github.com/apache/druid/pull/10191#discussion_r469349161
##########
File path:
server/src/main/java/org/apache/druid/segment/loading/StorageLocation.java
##########
@@ -134,6 +134,8 @@ public synchronized File reserve(String
segmentFilePathToAdd, String segmentId,
currSizeBytes += segmentSize;
return segmentFileToAdd;
} else {
+ log.error("No space is reserced or druid.segmentCache.locations is
reached maxSize in location [%s], " +
Review comment:
A warning message is already logged in `canHandle` that describes the
specific issue it ran into in case `canHandle` returns false. Is there
something in that warning message that could be improved?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
