capistrant commented on a change in pull request #10280:
URL: https://github.com/apache/druid/pull/10280#discussion_r471146224
##########
File path:
server/src/main/java/org/apache/druid/server/coordinator/DruidCoordinator.java
##########
@@ -733,11 +762,24 @@ public void run()
catch (Exception e) {
log.makeAlert(e, "Caught exception, ignoring so that schedule keeps
going.").emit();
}
- finally {
- if (balancerExec != null) {
- balancerExec.shutdownNow();
Review comment:
do we need to worry about abandoning resources after removing this?
Should the exec possibly be shutdown in stopBeingLeader() in your patch?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
