himanshug commented on a change in pull request #10277:
URL: https://github.com/apache/druid/pull/10277#discussion_r472515583
##########
File path:
processing/src/main/java/org/apache/druid/segment/incremental/IncrementalIndex.java
##########
@@ -314,7 +315,12 @@ protected IncrementalIndex(
for (DimensionSchema dimSchema : dimensionsSpec.getDimensions()) {
ValueType type = TYPE_MAP.get(dimSchema.getValueType());
String dimName = dimSchema.getName();
- ColumnCapabilitiesImpl capabilities =
makeDefaultCapabilitiesFromValueType(type);
+
+ // Note: Things might be simpler if DimensionSchema had a method
"getColumnCapabilities()" which could return
+ // type specific capabilities by itself. However, for various reasons,
DimensionSchema currently lives in druid-core
+ // while ColumnCapabilities lives in druid-processing which makes that
approach difficult.
+ ColumnCapabilitiesImpl capabilities =
makeDefaultCapabilitiesFromValueType(type, dimSchema.getTypeName());
Review comment:
it should be alright, I will update this PR later when I have my
MapStringString extension ready/deployed and tested with changes in this patch.
thanks for the heads up.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
