abhishekagarwal87 commented on a change in pull request #9638:
URL: https://github.com/apache/druid/pull/9638#discussion_r472782523



##########
File path: 
processing/src/main/java/org/apache/druid/query/aggregation/AggregatorFactory.java
##########
@@ -211,22 +213,35 @@ public AggregatorFactory 
getMergingFactory(AggregatorFactory other) throws Aggre
   public abstract List<String> requiredFields();
 
   /**
-   * Get the type name of the intermediate type for this aggregator. This is 
the same as the type returned by
+   * Get the "intermediate" {@link ValueType} for this aggregator. This is the 
same as the type returned by
    * {@link #deserialize} and the type accepted by {@link #combine}. However, 
it is *not* necessarily the same type
    * returned by {@link #finalizeComputation}.
+   */
+  public abstract ValueType getType();

Review comment:
       over time, more information can be added to this class rather than 
having methods in the interface. one example is complex type name. 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to