spinatelli opened a new pull request #10314:
URL: https://github.com/apache/druid/pull/10314


   (porting code from https://github.com/apache/druid/pull/9096)
   
   Fixes #8806.
   
   ### Description
   This is an update to the code in PR 9096 
(https://github.com/apache/druid/pull/9096), since it's stale. I report the 
original description and the changes I made
   
   Enhancing schema registry client i.e. SchemaRegistryBasedAvroBytesDecoder to 
accept additional configs, headers and able to query schemas from multi schema 
registry instances.
   
   - Changed SchemaRegistryBasedAvroBytesDecoder to accept config and headers 
as JSON properties.
   - Added support to pass multiple URLs for multiple schema registry instances 
by passing them as an array
   - Upgraded Confluent version to 5.5.1, which is compatible with existing 
kafka version: 2.6.0
   - Changed deprecated method getByID to getById.
   
   <hr>
   
   **Key changed/added classes in this PR**
   
   This PR has:
   - [x] been self-reviewed.
   - [x] added documentation for new or modified features or behaviors.
   - [x] added or updated version, license, or notice information in 
[licenses.yaml](https://github.com/apache/druid/blob/master/licenses.yaml)
   - [x] added comments explaining the "why" and the intent of the code 
wherever would not be obvious for an unfamiliar reader.
   - [x] added unit tests or modified existing tests to cover new code paths, 
ensuring the threshold for [code 
coverage](https://github.com/apache/druid/blob/master/dev/code-review/code-coverage.md)
 is met.
   - [x] been tested in a test Druid cluster.
   
   <hr>
   
   ##### Key changed/added classes in this PR
    * `SchemaRegistryBasedAvroBytesDecoder`
    * `SchemaRegistryBasedAvroBytesDecoderTest`
    * Updated libraries
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to