gianm edited a comment on pull request #10313: URL: https://github.com/apache/druid/pull/10313#issuecomment-679780301
> I see a comment on `NUMERIC_HASHING_THRESHOLD` that talks about benchmarks, but I couldn't find any > in the codebase It looks like the code was originally using a `HashSet<Long>`, which would be quite a bit slower than the LongOpenHashSet it uses today, so the original benchmarks aren't valid anymore. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
