gianm commented on a change in pull request #9638:
URL: https://github.com/apache/druid/pull/9638#discussion_r476250530
##########
File path:
processing/src/main/java/org/apache/druid/query/aggregation/post/ExpressionPostAggregator.java
##########
@@ -179,6 +169,14 @@ public String getName()
return name;
}
+ @Override
+ public ValueType getType()
+ {
+ // this is wrong, replace with Expr output type based on the input types
once it is available
+ // but treat as string for now
+ return ValueType.STRING;
Review comment:
I think it'd be good to make it `@Nullable` for now, with a note that
we'd like it to stop being nullable in the future when X/Y/Z things are done.
We want to make sure that in the meantime, we don't forget to check it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
