clintropolis commented on pull request #9638: URL: https://github.com/apache/druid/pull/9638#issuecomment-680254649
>I was asking what you thought 🙂 Ah, I guess where I was going with my meandering comment is that I'm not really worried about stuff at this point, but wasn't sure if there is anything I'm not thinking of. The 2 potential areas of risks are for places that are handling `ValueType` that are not prepared to handle array types, and similarly, for row signature stuff, changes due to types which were previously expressed as `null` now having additional type information, and again not being prepare for explict complex or array types. I think the array types are a good inclusion to `ValueType` since it allows us to more fully model reality, so that seems worth the small risk. The `RowSignature` change to include information seems harmless, but as mentioned would also be pretty easy to allow config to disable and revert to the previous behavior of only including primitive types in the signatures if we want to play it safe. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
