suneet-s opened a new pull request #10338:
URL: https://github.com/apache/druid/pull/10338


   ### Description
   
   This patch provides a vectorized implementation of the `ANY` aggregators. 
Since these aggregators already only read 1 value from the column, the 
performance gain comparing a vectorized implementation and non-vectorized 
implementation is expected to be minimal (maybe even slightly slower since we 
read a batch of values).
   
   However, providing a vectorized implementation allows for queries of the 
following shape to be vectorized
   
   ```
   SELECT id, ANY_VALUE(name), SUM(number) from datasource group by id
   ```
   where we know there is a 1:1 mapping between id and name
   
   Still WIP - The implementation is rough (lots of copy paste that will be 
consolidated), and tests are missing. Pushing up the PR so I don't lose track 
of it locally.
   
   <hr>
   
   This PR has:
   - [ ] been self-reviewed.
      - [ ] using the [concurrency 
checklist](https://github.com/apache/druid/blob/master/dev/code-review/concurrency.md)
 (Remove this item if the PR doesn't have any relation to concurrency.)
   - [ ] added documentation for new or modified features or behaviors.
   - [ ] added Javadocs for most classes and all non-trivial methods. Linked 
related entities via Javadoc links.
   - [ ] added or updated version, license, or notice information in 
[licenses.yaml](https://github.com/apache/druid/blob/master/licenses.yaml)
   - [ ] added comments explaining the "why" and the intent of the code 
wherever would not be obvious for an unfamiliar reader.
   - [ ] added unit tests or modified existing tests to cover new code paths, 
ensuring the threshold for [code 
coverage](https://github.com/apache/druid/blob/master/dev/code-review/code-coverage.md)
 is met.
   - [x] added integration tests.
   - [ ] been tested in a test Druid cluster.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to