FrankChen021 edited a comment on pull request #10383: URL: https://github.com/apache/druid/pull/10383#issuecomment-691386393
@gianm @jihoonson Thanks for the suggestions. Option 2 is much easier for us to control. I would like to do it as the following. As parameter `lineSplittable` is introduced on JsonInputFormat, to make the code easy to maintain, there will be two json reader classes named as `JsonReader` and `JsonLineReader`. The former one is the one which directly inherits `InputEntityReader` and uses `ObjectMapper.readValues` to parse input text. And `JsonLineReader` is renamed from the orignal `JsonReader` which inherits `TextReader` to process json text line by line. Both of them are instantiated by `JsonInputFormat` based on the value of `lineSplittable`. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
