jihoonson commented on a change in pull request #10379:
URL: https://github.com/apache/druid/pull/10379#discussion_r489123722



##########
File path: 
indexing-service/src/main/java/org/apache/druid/indexing/overlord/TaskRunner.java
##########
@@ -121,4 +121,17 @@ default TaskLocation getTaskLocation(String taskId)
    * @return ScalingStats if the runner has an underlying resource which can 
scale, Optional.absent() otherwise
    */
   Optional<ScalingStats> getScalingStats();
+
+  /**
+   * APIs useful for emitting statistics for @TaskSlotCountStatsMonitor
+  */
+  long getTotalTaskSlotCount();

Review comment:
       How about adding new interfaces such as `TaskSlotCountable` and 
`WorkerCountable`? Then, we can avoid implementing unnecessary interfaces, 
e.g., the new methods in `SingleThreadedBackgroundRunner`, by implementing 
required interfaces only.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to