maytasm commented on a change in pull request #10371:
URL: https://github.com/apache/druid/pull/10371#discussion_r489223414
##########
File path:
server/src/test/java/org/apache/druid/server/coordinator/duty/CompactSegmentsTest.java
##########
@@ -270,12 +275,246 @@ public String get()
assertLastSegmentNotCompacted(compactSegments);
}
+ @Test
+ public void testMakeStats()
Review comment:
I feel that each test is already doing a lot. Combining them will make
the tests hard to understand as it will be testing and verifying many many many
things. They are also not duplicated code as they are verifying different
things so I think it is fine to separate them.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
