FrankChen021 commented on a change in pull request #10363:
URL: https://github.com/apache/druid/pull/10363#discussion_r490141864
##########
File path:
server/src/main/java/org/apache/druid/segment/loading/SegmentLoaderConfig.java
##########
@@ -54,9 +54,6 @@
@JsonProperty("numBootstrapThreads")
private Integer numBootstrapThreads = null;
- @JsonProperty("locationSelectorStrategy")
- private StorageLocationSelectorStrategy locationSelectorStrategy;
Review comment:
This is because `StorageLocationStrategy` depends on
`SegmentLoaderConfig.locations`. If `StorageLocationStrategy` is placed here,
when `SegmentLoaderConfig` is being deserialized, `locations` required by
`StorageLocationStrategy` can't be found and injected into it.
After moving this property out of `SegmentLoaderConfig`, both
`SegmentLoaderConfig` and `StorageLocationStrategy` are deserialized during
construction of `SegmentLoaderLocalCacheManager`, and jackson could find the
`locations` objects required by strategy object through google guice framework
to create strategy object correctly.
Using the configuration name without `type` I think is wrong. Please take a
look at this configuration `druid.coordinator.balancer.strategy`, or the
clarification on the change of configuration name I left above.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
