FrankChen021 commented on pull request #10383: URL: https://github.com/apache/druid/pull/10383#issuecomment-694798148
@jihoonson I intended to do that, but after some deep investigation of original implementation, I found that it was not the root cause of previous problem. As a result, exception handling in the new `JsonReader.sample` was improved, as the way it did in `IntermediateRowParsingReader`, to eliminate the failure of test cases. So neither test cases nor sample and ingestion behaviors were modified to adapt to this PR. The PR is now ready for review. I would like hear your voices with regarding to the pass of value of `lineSplittable` parameter, which I think there should be a more graceful way. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
