pjain1 commented on pull request #10407: URL: https://github.com/apache/druid/pull/10407#issuecomment-696514467
> To do so, I have been thinking to add new classes each of which defines all metrics useful for batch and streaming ingestion, respectively. I'm not sure why we should keep metrics separately in different classes such as the bytes ingested in InputStats added in this PR. Does this make sense? I added this class with the vision that more metrics can be added in future regarding ingestion as this class is available at task and InputSource/InputEntity level as well. Also I don't see `FireDepartmentMetrics` being used in batch tasks apart from `SinglePhaseSubTask`, so I though a new framework of `InputStatsMonitor` which is enabled by default with `InputStats` can be used which can be expanded to include ingestion stats similar to one being reported by kafka indexing task. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
