jon-wei opened a new pull request #10420:
URL: https://github.com/apache/druid/pull/10420
This PR adds a new `ingest/merge/count` metric that records how many
intermediate persists have been merged for publishing.
Additionally, this PR enables the existing `ingest/merge/time` and
`ingest/merge/cpu` metrics for `AppenderatorImpl`, which were only being
updated in `RealtimePlumber`.
Marking WIP since in a test cluster I'm seeing discrepancies in the total
sums of `ingest/persist/count` and the new `ingest/merge/count`, which I would
expect to be the same, need to investigate that further. Also I observed
ingestion related metrics not being emitted when a batch task shuts down, which
should be looked into as well.
This PR has:
- [x] been self-reviewed.
- [ ] using the [concurrency
checklist](https://github.com/apache/druid/blob/master/dev/code-review/concurrency.md)
(Remove this item if the PR doesn't have any relation to concurrency.)
- [x] added documentation for new or modified features or behaviors.
- [ ] added Javadocs for most classes and all non-trivial methods. Linked
related entities via Javadoc links.
- [ ] added or updated version, license, or notice information in
[licenses.yaml](https://github.com/apache/druid/blob/master/licenses.yaml)
- [ ] added comments explaining the "why" and the intent of the code
wherever would not be obvious for an unfamiliar reader.
- [ ] added unit tests or modified existing tests to cover new code paths,
ensuring the threshold for [code
coverage](https://github.com/apache/druid/blob/master/dev/code-review/code-coverage.md)
is met.
- [ ] added integration tests.
- [x] been tested in a test Druid cluster.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
