clintropolis opened a new pull request #10422:
URL: https://github.com/apache/druid/pull/10422


   ### Description
   Adds a light weight verison of `/druid/coordinator/v1/lookups/nodeStatus`, 
which currently include the lookup spec JSON, which can be sort of large for 
inline map lookups:
   
   ```json
   {
     "__default": {
       "localhost:8083": {
         "current": {
           "lookup_table": {
             "version": "2020-06-11T10:48:17.033Z",
             "lookupExtractorFactory": {
               "type": "cachedNamespace",
               "extractionNamespace": {
                 "type": "uri",
                 "uri": null,
                 "uriPrefix": 
"file:/Users/clint/workspace/data/druid/lookups/lookup-simple.json",
                 "fileRegex": null,
                 "namespaceParseSpec": {
                   "format": "simpleJson"
                 },
                 "pollPeriod": "PT0S"
               },
               "firstCacheTimeout": 0,
               "injective": true
             }
           }
         },
         "toLoad": {},
         "toDrop": []
       }
     }
   }
   ```
   
   Using `/druid/coordinator/v1/lookups/nodeStatus?detailed=false` will instead 
just include the 'version' string instead of the complete lookup JSON spec:
   
   ```json
   {
     "__default": {
       "localhost:8083": {
         "current": {
           "lookup_table": "2020-06-11T10:48:17.033Z"
         },
         "toLoad": {},
         "toDrop": []
       }
     }
   }
   ```
   
   The new parameter defaults to true if not set to preserve existing behavior.
   
   <hr>
   
   This PR has:
   - [x] been self-reviewed.
   - [x] added documentation for new or modified features or behaviors.
   - [x] added comments explaining the "why" and the intent of the code 
wherever would not be obvious for an unfamiliar reader.
   - [x] added unit tests or modified existing tests to cover new code paths, 
ensuring the threshold for [code 
coverage](https://github.com/apache/druid/blob/master/dev/code-review/code-coverage.md)
 is met.
   - [ ] added integration tests.
   - [x] been tested in a test Druid cluster.
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to