clintropolis opened a new pull request #10432: URL: https://github.com/apache/druid/pull/10432
### Description Follow-up to #10401, this PR adds an escape hatch in case anything goes wrong in the form of a new query context parameter, `vectorizeVirtualColumns`, which follows the same pattern as `vectorize` with options `false`, `true`, `force`. This context parameter is layered on top of `vectorize`, which also must be set to `true` for a query to use vectorized engines, but _can_ be set to `false` to disable vectorization selectively for only queries with virtual columns by default with ``` druid.query.default.context.vectorizeVirtualColumns=false ``` in `runtime.properties` in the event of any bugs resulting from the vectorized expression virtual columns added in #10401. <hr> This PR has: - [x] been self-reviewed. - [x] added documentation for new or modified features or behaviors. - [ ] added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links. - [ ] added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader. - [x] added unit tests or modified existing tests to cover new code paths, ensuring the threshold for [code coverage](https://github.com/apache/druid/blob/master/dev/code-review/code-coverage.md) is met. - [ ] added integration tests. - [ ] been tested in a test Druid cluster. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
