jihoonson opened a new pull request #10452:
URL: https://github.com/apache/druid/pull/10452
### Description
There are 2 issues in `VectorGroupByEngine`.
- When `HashVectorGrouper` is used, `AggregatorAdaptors` is never closed.
- When `BufferArrayGrouper` is used, the same `AggregatorAdaptors` can be
used after it is closed since the same `grouper` instance is used to create
`delegate`s which are `CloseableGrouperIterator`.
The von-vectorized groupBy engine doesn't have this issue because it creates
a new `grouper` per `delegate`. This PR fixes the issue in
`VectorGroupByEngine` by modifying its behavior to create a new `grouper` per
`delegate` as in the non-vectorized version.
<hr>
This PR has:
- [x] been self-reviewed.
- [ ] using the [concurrency
checklist](https://github.com/apache/druid/blob/master/dev/code-review/concurrency.md)
(Remove this item if the PR doesn't have any relation to concurrency.)
- [ ] added documentation for new or modified features or behaviors.
- [ ] added Javadocs for most classes and all non-trivial methods. Linked
related entities via Javadoc links.
- [ ] added or updated version, license, or notice information in
[licenses.yaml](https://github.com/apache/druid/blob/master/licenses.yaml)
- [ ] added comments explaining the "why" and the intent of the code
wherever would not be obvious for an unfamiliar reader.
- [x] added unit tests or modified existing tests to cover new code paths,
ensuring the threshold for [code
coverage](https://github.com/apache/druid/blob/master/dev/code-review/code-coverage.md)
is met.
- [ ] added integration tests.
- [ ] been tested in a test Druid cluster.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
