Tiaaa commented on a change in pull request #10412:
URL: https://github.com/apache/druid/pull/10412#discussion_r499157969
##########
File path:
extensions-contrib/prometheus-emitter/src/main/resources/defaultMetrics.json
##########
@@ -0,0 +1,128 @@
+{
+ "query/time" : { "dimensions" : ["dataSource", "type"], "type" : "timer",
"conversionFactor": 1000.0, "help": "Seconds taken to complete a query."},
Review comment:
https://prometheus.io/docs/practices/naming/#base-units
It's coming from prometheus common practice.
cc @michaelschiff
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
