maytasm commented on a change in pull request #10479:
URL: https://github.com/apache/druid/pull/10479#discussion_r499816852
##########
File path:
server/src/main/java/org/apache/druid/server/coordinator/duty/CompactSegments.java
##########
@@ -277,7 +300,8 @@ private CoordinatorStats doRun(
);
LOG.infoSegments(segmentsToCompact, "Compacting segments");
// Count the compaction task itself + its sub tasks
- numSubmittedTasks +=
findNumMaxConcurrentSubTasks(config.getTuningConfig()) + 1;
+ numSubmittedTasks++;
Review comment:
Why do we need both numSubmittedTasks and numCompactionTasksAndSubtasks?
If we are using numSubmittedTasks as the stats, then the stat will be
different. Previously, it includes subtasks and now it doesn't. Maybe this
should be documented? Otherwise you might see your stat for this changed
drastically.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
