maytasm commented on a change in pull request #10481:
URL: https://github.com/apache/druid/pull/10481#discussion_r499919274



##########
File path: 
sql/src/main/java/org/apache/druid/sql/calcite/schema/SystemSchema.java
##########
@@ -142,7 +143,7 @@
       .add("is_available", ValueType.LONG)
       .add("is_realtime", ValueType.LONG)
       .add("is_overshadowed", ValueType.LONG)
-      .add("shardSpec", ValueType.STRING)
+      .add("shard_spec", ValueType.STRING)

Review comment:
       I don't think there is anything in Druid depending on shardSpec (similar 
to how the linked PR changed payload to shardSpec, metrics, dimensions). I can 
update the document but I don't think anything will break. I guess unless 
someone has a custom script reading this field which is probably unlikely and 
is why we should change this ASAP.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to