gianm commented on a change in pull request #10467:
URL: https://github.com/apache/druid/pull/10467#discussion_r500579681
##########
File path:
extensions-core/kinesis-indexing-service/src/main/java/org/apache/druid/indexing/kinesis/KinesisRecordSupplier.java
##########
@@ -552,8 +552,11 @@ public void start()
}
}
+ /**
+ * This method is synchronized because multiple threads can attempt to close
the record supplier concurrently
+ */
@Override
- public void close()
+ public synchronized void close()
Review comment:
I do think it should be fixed now, ideally, because we can't be
confident that this patch actually fixes the bug without fixing the thread
safety issue too.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
