liran-funaro commented on pull request #10335: URL: https://github.com/apache/druid/pull/10335#issuecomment-705564572
Thanks, @a2l007 I addressed all your comments in the codes, or with follow-up questions. Regarding the integration tests, I added tests to all the `TuningConfig` tests that validate the `AppendableIndexSpec` within `TuningConfig`. I think it is sufficient. Do you agree? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
