suneet-s commented on pull request #10363: URL: https://github.com/apache/druid/pull/10363#issuecomment-708525495
> @suneet-s Got it. I'm not familiar with IT. One thing I don't understand is what we should expect from the integration tests. To verify if the right type of selector object injected for corresponding configuration? @FrankChen021 I think the ITs should test that Druid uses the `StorageLocationSelector` that was configured by the user by looking at the user visible impact of changing this setting. So for example: A user who sets this to `mostAvailableSize` should see that segments are loaded on the historical with the most available size instead of the default which is least bytes used. Constructing a scenario where this behavior difference should occur may be tricky. I haven't had the time to think about how to construct this scenario yet. I will get back to you on my tests today. Thanks again for your patience ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
