liuxiaohui1221 opened a new pull request #10531:
URL: https://github.com/apache/druid/pull/10531
<!-- Thanks for trying to help us make Apache Druid be the best it can be!
Please fill out as much of the following information as is possible (where
relevant, and remove it when irrelevant) to help make the intention and scope
of this PR clear in order to ease review. -->
Fixes #6743 .
When the data source has one or more
thetasketch,quantilesDoublesSketch,ingestion task(when maxBytesInMemory not -1)
will generate a lot of small files and will trigger off heap OOM when merge
this spill files.
<!-- Replace XXXX with the id of the issue fixed in this PR. Remove this
section if there is no corresponding issue. Don't reference the issue in the
title of this pull-request. -->
<!-- If you are a committer, follow the PR action item checklist for
committers:
https://github.com/apache/druid/blob/master/dev/committer-instructions.md#pr-and-issue-action-item-checklist-for-committers.
-->
### Description
Add a internal Aggregator to fix overestimate
`thetaSketch`,`quantilesDoublesSketch`.
This is a better way than #10241 on aggregation performance. Open to adjust
bytesInMemory does not affect aggregation performance, The following are the
aggregation test results:
<!-- Describe the goal of this PR, what problem are you fixing. If there is
a corresponding issue (referenced above), it's not necessary to repeat the
description here, however, you may choose to keep one summary sentence. -->
```
Benchmark (adjustFlag)
(maxBytesInMemory) (rollup) (rollupOpportunity) (rowsPerSegment) (schema)
Mode Cnt Score Error Units
ComplexMetricAdjustStrategyBenchmark.addRows true
20000000000 true low 75000 complex avgt
10 77019.343 ± 4248.190 us/op
ComplexMetricAdjustStrategyBenchmark.addRows true
20000000000 true moderate 75000 complex avgt
10 87820.211 ± 7365.937 us/op
ComplexMetricAdjustStrategyBenchmark.addRows true
20000000000 true high 75000 complex avgt
10 86945.918 ± 9498.552 us/op
ComplexMetricAdjustStrategyBenchmark.addRows false
20000000000 true low 75000 complex avgt
10 75927.136 ± 8089.762 us/op
ComplexMetricAdjustStrategyBenchmark.addRows false
20000000000 true moderate 75000 complex avgt
10 87066.440 ± 11407.226 us/op
ComplexMetricAdjustStrategyBenchmark.addRows false
20000000000 true high 75000 complex avgt
10 93060.885 ± 9937.165 us/op
```
<!-- Describe your patch: what did you change in code? How did you fix the
problem? -->
<!-- If there are several relatively logically separate changes in this PR,
create a mini-section for each of them. For example: -->
#### Fixed the bug ...
#### Renamed the class ...
#### Added a forbidden-apis entry ...
<!--
In each section, please describe design decisions made, including:
- Choice of algorithms
- Behavioral aspects. What configuration values are acceptable? How are
corner cases and error conditions handled, such as when there are insufficient
resources?
- Class organization and design (how the logic is split between classes,
inheritance, composition, design patterns)
- Method organization and design (how the logic is split between methods,
parameters and return types)
- Naming (class, method, API, configuration, HTTP endpoint, names of
emitted metrics)
-->
<!-- It's good to describe an alternative design (or mention an alternative
name) for every design (or naming) decision point and compare the alternatives
with the designs that you've implemented (or the names you've chosen) to
highlight the advantages of the chosen designs and names. -->
<!-- If there was a discussion of the design of the feature implemented in
this PR elsewhere (e. g. a "Proposal" issue, any other issue, or a thread in
the development mailing list), link to that discussion from this PR description
and explain what have changed in your final design compared to your original
proposal or the consensus version in the end of the discussion. If something
hasn't changed since the original discussion, you can omit a detailed
discussion of those aspects of the design here, perhaps apart from brief
mentioning for the sake of readability of this PR description. -->
<!-- Some of the aspects mentioned above may be omitted for simple and small
changes. -->
<hr>
This PR has:
-
>
- [✓ ] been self-reviewed.
[ ✓] added or updated version, license, or notice information in
[licenses.yaml](https://github.com/apache/druid/blob/master/licenses.yaml)
- [ ] added comments explaining the "why" and the intent of the code
wherever would not be obvious for an unfamiliar reader.
[ ✓] added unit tests or modified existing tests to cover new code paths,
ensuring the threshold for [code
coverage](https://github.com/apache/druid/blob/master/dev/code-review/code-coverage.md)
is met.
- [ ] added integration tests.
- [ ] been tested in a test Druid cluster.
<!-- Check the items by putting "x" in the brackets for the done things. Not
all of these items apply to every PR. Remove the items which are not done or
not relevant to the PR. None of the items from the checklist above are strictly
necessary, but it would be very helpful if you at least self-review the PR. -->
<hr>
##### Key changed/added classes in this PR
* `MaxIntermediateSizeAdjustStrategy`
* `ThetaSketchSizeAdjustStrategy`
* `DoublesSketchSizeAdjustStrategy`
* `InternalCountAdjustmentAggregator`
* `OnheapIncrementalIndex`
* `AggregatorFactory`
......
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
