leventov commented on a change in pull request #10448:
URL: https://github.com/apache/druid/pull/10448#discussion_r512203193
##########
File path:
core/src/main/java/org/apache/druid/java/util/common/concurrent/ScheduledExecutors.java
##########
@@ -167,6 +169,50 @@ public void run()
);
}
+ public static void scheduleAtFixedRate(CronScheduler exec, Duration rate,
Callable<Signal> callable)
+ {
+ scheduleAtFixedRate(exec, rate, rate, callable);
+ }
+
+ /**
+ * Run callable once every period, after the given initial delay. Uses
+ * {@link CronScheduler} for task scheduling. Exceptions are caught and
logged
+ * as errors.
+ */
+ public static void scheduleAtFixedRate(
+ final CronScheduler exec,
+ final Duration initialDelay,
+ final Duration rate,
+ final Callable<Signal> callable
+ )
+ {
+ log.debug("Scheduling periodically: %s with period %s", callable, rate);
+ Instant delayInstance = Instant.now().plusMillis(initialDelay.getMillis());
+ exec.scheduleAt(delayInstance,
Review comment:
There should be a separate future for every monitor. I also think there
should be a separate executorService for running `monitor.monitor(emitter)`,
and cancelling the future from the first monitor, for two reasons:
1. Monitor code is not guaranteed to be non-blocking and "cheap", which is
the requirement of CronScheduler;
2. You can avoid having a race condition of cancelling a future on the
first iteration when it's not yet created.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
