nishantmonu51 commented on a change in pull request #10532:
URL: https://github.com/apache/druid/pull/10532#discussion_r512930964
##########
File path: docs/development/extensions-core/druid-basic-security.md
##########
@@ -62,16 +69,16 @@
druid.auth.authenticator.MyBasicMetadataAuthenticator.authorizerName=MyBasicMeta
```
To use the Basic authenticator, add an authenticator with type `basic` to the
authenticatorChain.
-The authenticator needs to also define a credentialsValidator with type
'metadata' or 'ldap'.
-If credentialsValidator is not specified, type 'metadata' will be used as
default.
+The authenticator must define a credentials validator `credentialsValidator`
with type 'metadata' or 'ldap'.
+Otherwise the credentials validator defaults to `metadata` if you do not
specify another type.
Review comment:
above 2 lines seems to be contradictory, first one says you must define
it and 2nd mentions a default value.
probably, reword as - "The authenticator uses metadata credentials validator
by default which can be configured to `metadata`." Or similar wordings.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
