FrankChen021 commented on a change in pull request #10551:
URL: https://github.com/apache/druid/pull/10551#discussion_r521258336
##########
File path:
extensions-core/kafka-indexing-service/src/main/java/org/apache/druid/indexing/kafka/KafkaConsumerConfigs.java
##########
@@ -30,15 +30,23 @@
*/
public class KafkaConsumerConfigs
{
-
- public static Map<String, Object> getConsumerProperties()
+ public static Map<String, Object> getConsumerProperties(Map<String, Object>
customerConsumerProperties)
{
+ final Object value =
customerConsumerProperties.remove("consumeTransactionally");
Review comment:
Putting this property in `KafkaIndexTaskIOConfig.consumerProperties`
might cause some confusion. `consumerProperties` is designed to store kafka
official properties. It's better to put the new property in
`KafkaIndexTaskIOConfig` directly and put the code related to this property in
`KafkaRecordSupplier.addConsumerPropertiesFromConfig`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
