himanshug commented on a change in pull request #10591:
URL: https://github.com/apache/druid/pull/10591#discussion_r526476418
##########
File path: distribution/docker/druid.sh
##########
@@ -148,5 +148,10 @@ then
echo "$DRUID_LOG4J" >$COMMON_CONF_DIR/log4j2.xml
fi
-mkdir -p var/tmp var/druid/segments var/druid/indexing-logs var/druid/task
var/druid/hadoop-tmp var/druid/segment-cache
+DRUID_DIRS_TO_CREATE=${DRUID_DIRS_TO_CREATE-'var/tmp var/druid/segments
var/druid/indexing-logs var/druid/task var/druid/hadoop-tmp
var/druid/segment-cache'}
+if [ "X${DRUID_DIRS_TO_CREATE}" != "X" ]
Review comment:
mostly muscle memory I think, didn't pay enough attention to other parts
of script while I made the change.
changed to be more idiomatic .
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
