capistrant edited a comment on pull request #10578: URL: https://github.com/apache/druid/pull/10578#issuecomment-729964748
Hmm, I appear to be having an inspection problem after my `00efa42` commit. `QueryMetrics#context` is getting flagged with `Method is never used as a member of this interface, but only as a member of the implementation class(es). The project will stay compilable if the method is removed from the interface.` ... However, I do not see the difference between this method or any of the other override methods that don't have an inspection error. I'll keep digging, if anyone has some tips, let me know. Update: Had to add method to `@publicapi` in metrics interface now that it is not invoked from outside the implementation class anymore. matches what has been done with the other default dimensions that are not used from outside the class. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
