himanshug commented on a change in pull request #10603:
URL: https://github.com/apache/druid/pull/10603#discussion_r530036883
##########
File path:
server/src/main/java/org/apache/druid/server/coordinator/DruidCoordinator.java
##########
@@ -801,14 +811,24 @@ public void run()
&& coordLeaderSelector.isLeader()
&& startingLeaderCounter == coordLeaderSelector.localTerm()) {
+ final long start = System.nanoTime();
params = duty.run(params);
+ final long end = System.nanoTime();
if (params == null) {
// This duty wanted to cancel the run. No log message, since the
duty should have logged a reason.
return;
+ } else {
+ params.getCoordinatorStats().addToDutyStat("runtime",
duty.getDutyAlias(), TimeUnit.NANOSECONDS.toMillis(end - start));
Review comment:
will it be ok to just use "duty.getClass().getName()" for this use case
instead of extending the interface?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
