clintropolis opened a new pull request #10605: URL: https://github.com/apache/druid/pull/10605
### Description This PR picks up the commit from #10230, which adds bitwise math functions (`bitwiseAnd`, `bitwiseComplement` , `bitwiseOr`, `bitwiseShiftLeft`, `bitwiseShiftRight`, `bitwiseXor`) to the Druid native expression system. A difference between the original PR and this one is a modification to how double values are handled, which will now be implicitly converted to long values with `Double.doubleToLongBits` instead of a cast, in an attempt to make the functions more flexible. To go along with this, there is also now a `bitwiseConvertDouble` which will convert double inputs to longs using `Double.doubleToLongBits`, and long inputs to doubles using `Double.longBitsToDouble`. Finally, I've added vectorization support so these expressions can be utilized in vectorized query engines, as well as tests. I'll save adding SQL support as a follow-up PR. Related #8560 <hr> This PR has: - [x] been self-reviewed. - [x] added documentation for new or modified features or behaviors. - [ ] added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links. - [ ] added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader. - [x] added unit tests or modified existing tests to cover new code paths, ensuring the threshold for [code coverage](https://github.com/apache/druid/blob/master/dev/code-review/code-coverage.md) is met. - [ ] added integration tests. - [x] been tested in a test Druid cluster. <hr> ##### Key changed/added classes in this PR * `Function` * `VectorMathProcessors` ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
