zhangyue19921010 commented on pull request #10524: URL: https://github.com/apache/druid/pull/10524#issuecomment-734924077
> This is a super cool idea. I have begun a review and included comments/questions/suggestions. > > initial takeaways: > > * Docs, lets get all the new IOConfig stuff documented in .md files > * Javadocs, would be great to get javadocs created for all the new methods, especially the more critical/complex ones > * logging. Lots of logging that does not provide information about the supervisor that is logging. Also I think we can do some scaling back on what gets info level. Some logs seemed better off for debug. > * logging 2. in places where we catch errors and just continue on, should we log warn instead of error? > * configuration: For the new config block in IOconfig, is there anyway to have a POJO structure for this new block? If not that, I think at least extracting the default values out to final variables in the classes they live would help make things easier to follow. > @capistrant Hi capistrant, all the changes are done and test on dev cluster. PTAL :) ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
