himanshug commented on a change in pull request #10551:
URL: https://github.com/apache/druid/pull/10551#discussion_r535759359
##########
File path:
extensions-core/kafka-indexing-service/src/main/java/org/apache/druid/indexing/kafka/KafkaConsumerConfigs.java
##########
@@ -31,14 +31,14 @@
public class KafkaConsumerConfigs
{
- public static Map<String, Object> getConsumerProperties()
+ public static Map<String, Object> getConsumerProperties(Map<String, Object>
customerConsumerProperties)
Review comment:
> we need to ensure that the deserialize between new IoConfig and old
IoConfig is completely consistent and smooth
well, my main concern was the `consumeTransactionally` param which has been
removed . Though I fail to see why simply adding the default to
`KafkaSupervisorIOConfig.java` would not have same behavior functionally (or
for backward compatibility as well)... but I am not so worried about the
specifics at this point as it is easy to change later if needed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
