This is an automated email from the ASF dual-hosted git repository.
cwylie pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/druid.git
The following commit(s) were added to refs/heads/master by this push:
new 52d46ce Move common configurations to TuningConfig (#10478)
52d46ce is described below
commit 52d46cebc31026b8dd39c7d9fb82c62bd77965fb
Author: Liran Funaro <[email protected]>
AuthorDate: Fri Dec 4 04:13:32 2020 +0200
Move common configurations to TuningConfig (#10478)
* Move common methods that are used in HadoopTuningConfig and in
AppenderatorConfig to TuningConfig
* Rename rowFlushBoundary in HadoopTuningConfig to maxRowsInMemory to match
TuningConfig API
---
.../MaterializedViewSupervisorSpec.java | 4 ++--
.../apache/druid/indexer/HadoopTuningConfig.java | 25 ++++++++++++----------
.../apache/druid/indexer/IndexGeneratorJob.java | 2 +-
.../druid/indexer/HadoopTuningConfigTest.java | 2 +-
.../druid/segment/indexing/TuningConfig.java | 13 +++++++++++
.../realtime/appenderator/AppenderatorConfig.java | 13 -----------
6 files changed, 31 insertions(+), 28 deletions(-)
diff --git
a/extensions-contrib/materialized-view-maintenance/src/main/java/org/apache/druid/indexing/materializedview/MaterializedViewSupervisorSpec.java
b/extensions-contrib/materialized-view-maintenance/src/main/java/org/apache/druid/indexing/materializedview/MaterializedViewSupervisorSpec.java
index 5388388..db63a73 100644
---
a/extensions-contrib/materialized-view-maintenance/src/main/java/org/apache/druid/indexing/materializedview/MaterializedViewSupervisorSpec.java
+++
b/extensions-contrib/materialized-view-maintenance/src/main/java/org/apache/druid/indexing/materializedview/MaterializedViewSupervisorSpec.java
@@ -182,7 +182,7 @@ public class MaterializedViewSupervisorSpec implements
SupervisorSpec
tuningConfig.getIndexSpec(),
tuningConfig.getIndexSpecForIntermediatePersists(),
tuningConfig.getAppendableIndexSpec(),
- tuningConfig.getRowFlushBoundary(),
+ tuningConfig.getMaxRowsInMemory(),
tuningConfig.getMaxBytesInMemory(),
tuningConfig.isLeaveIntermediate(),
tuningConfig.isCleanupOnFailure(),
@@ -191,7 +191,7 @@ public class MaterializedViewSupervisorSpec implements
SupervisorSpec
tuningConfig.getJobProperties(),
tuningConfig.isCombineText(),
tuningConfig.getUseCombiner(),
- tuningConfig.getRowFlushBoundary(),
+ tuningConfig.getMaxRowsInMemory(),
tuningConfig.getBuildV9Directly(),
tuningConfig.getNumBackgroundPersistThreads(),
tuningConfig.isForceExtendableShardSpecs(),
diff --git
a/indexing-hadoop/src/main/java/org/apache/druid/indexer/HadoopTuningConfig.java
b/indexing-hadoop/src/main/java/org/apache/druid/indexer/HadoopTuningConfig.java
index f1a8cc8..0f29f6a 100644
---
a/indexing-hadoop/src/main/java/org/apache/druid/indexer/HadoopTuningConfig.java
+++
b/indexing-hadoop/src/main/java/org/apache/druid/indexer/HadoopTuningConfig.java
@@ -44,7 +44,6 @@ public class HadoopTuningConfig implements TuningConfig
private static final DimensionBasedPartitionsSpec DEFAULT_PARTITIONS_SPEC =
HashedPartitionsSpec.defaultSpec();
private static final Map<Long, List<HadoopyShardSpec>> DEFAULT_SHARD_SPECS =
ImmutableMap.of();
private static final IndexSpec DEFAULT_INDEX_SPEC = new IndexSpec();
- private static final int DEFAULT_ROW_FLUSH_BOUNDARY =
TuningConfig.DEFAULT_MAX_ROWS_IN_MEMORY;
private static final boolean DEFAULT_USE_COMBINER = false;
private static final int DEFAULT_NUM_BACKGROUND_PERSIST_THREADS = 0;
@@ -58,7 +57,7 @@ public class HadoopTuningConfig implements TuningConfig
DEFAULT_INDEX_SPEC,
DEFAULT_INDEX_SPEC,
DEFAULT_APPENDABLE_INDEX,
- DEFAULT_ROW_FLUSH_BOUNDARY,
+ DEFAULT_MAX_ROWS_IN_MEMORY,
0L,
false,
true,
@@ -86,7 +85,7 @@ public class HadoopTuningConfig implements TuningConfig
private final IndexSpec indexSpec;
private final IndexSpec indexSpecForIntermediatePersists;
private final AppendableIndexSpec appendableIndexSpec;
- private final int rowFlushBoundary;
+ private final int maxRowsInMemory;
private final long maxBytesInMemory;
private final boolean leaveIntermediate;
private final boolean cleanupOnFailure;
@@ -141,8 +140,8 @@ public class HadoopTuningConfig implements TuningConfig
this.indexSpec = indexSpec == null ? DEFAULT_INDEX_SPEC : indexSpec;
this.indexSpecForIntermediatePersists = indexSpecForIntermediatePersists
== null ?
this.indexSpec :
indexSpecForIntermediatePersists;
- this.rowFlushBoundary = maxRowsInMemory == null ? maxRowsInMemoryCOMPAT ==
null
- ?
DEFAULT_ROW_FLUSH_BOUNDARY
+ this.maxRowsInMemory = maxRowsInMemory == null ? maxRowsInMemoryCOMPAT ==
null
+ ?
DEFAULT_MAX_ROWS_IN_MEMORY
: maxRowsInMemoryCOMPAT
: maxRowsInMemory;
this.appendableIndexSpec = appendableIndexSpec == null ?
DEFAULT_APPENDABLE_INDEX : appendableIndexSpec;
// initializing this to 0, it will be lazily initialized to a value
@@ -192,6 +191,7 @@ public class HadoopTuningConfig implements TuningConfig
return version;
}
+ @Override
@JsonProperty
public DimensionBasedPartitionsSpec getPartitionsSpec()
{
@@ -204,12 +204,14 @@ public class HadoopTuningConfig implements TuningConfig
return shardSpecs;
}
+ @Override
@JsonProperty
public IndexSpec getIndexSpec()
{
return indexSpec;
}
+ @Override
@JsonProperty
public IndexSpec getIndexSpecForIntermediatePersists()
{
@@ -223,10 +225,11 @@ public class HadoopTuningConfig implements TuningConfig
return appendableIndexSpec;
}
- @JsonProperty("maxRowsInMemory")
- public int getRowFlushBoundary()
+ @Override
+ @JsonProperty
+ public int getMaxRowsInMemory()
{
- return rowFlushBoundary;
+ return maxRowsInMemory;
}
@JsonProperty
@@ -341,7 +344,7 @@ public class HadoopTuningConfig implements TuningConfig
indexSpec,
indexSpecForIntermediatePersists,
appendableIndexSpec,
- rowFlushBoundary,
+ maxRowsInMemory,
maxBytesInMemory,
leaveIntermediate,
cleanupOnFailure,
@@ -372,7 +375,7 @@ public class HadoopTuningConfig implements TuningConfig
indexSpec,
indexSpecForIntermediatePersists,
appendableIndexSpec,
- rowFlushBoundary,
+ maxRowsInMemory,
maxBytesInMemory,
leaveIntermediate,
cleanupOnFailure,
@@ -403,7 +406,7 @@ public class HadoopTuningConfig implements TuningConfig
indexSpec,
indexSpecForIntermediatePersists,
appendableIndexSpec,
- rowFlushBoundary,
+ maxRowsInMemory,
maxBytesInMemory,
leaveIntermediate,
cleanupOnFailure,
diff --git
a/indexing-hadoop/src/main/java/org/apache/druid/indexer/IndexGeneratorJob.java
b/indexing-hadoop/src/main/java/org/apache/druid/indexer/IndexGeneratorJob.java
index 8925906..f369471 100644
---
a/indexing-hadoop/src/main/java/org/apache/druid/indexer/IndexGeneratorJob.java
+++
b/indexing-hadoop/src/main/java/org/apache/druid/indexer/IndexGeneratorJob.java
@@ -304,7 +304,7 @@ public class IndexGeneratorJob implements Jobby
// Build the incremental-index according to the spec that was chosen by
the user
IncrementalIndex newIndex = tuningConfig.getAppendableIndexSpec().builder()
.setIndexSchema(indexSchema)
- .setMaxRowCount(tuningConfig.getRowFlushBoundary())
+ .setMaxRowCount(tuningConfig.getMaxRowsInMemory())
.setMaxBytesInMemory(tuningConfig.getMaxBytesInMemoryOrDefault())
.build();
diff --git
a/indexing-hadoop/src/test/java/org/apache/druid/indexer/HadoopTuningConfigTest.java
b/indexing-hadoop/src/test/java/org/apache/druid/indexer/HadoopTuningConfigTest.java
index fce828b..277f590 100644
---
a/indexing-hadoop/src/test/java/org/apache/druid/indexer/HadoopTuningConfigTest.java
+++
b/indexing-hadoop/src/test/java/org/apache/druid/indexer/HadoopTuningConfigTest.java
@@ -75,7 +75,7 @@ public class HadoopTuningConfigTest
Assert.assertEquals(ImmutableMap.<Long, List<HadoopyShardSpec>>of(),
actual.getShardSpecs());
Assert.assertEquals(new IndexSpec(), actual.getIndexSpec());
Assert.assertEquals(new IndexSpec(),
actual.getIndexSpecForIntermediatePersists());
- Assert.assertEquals(100, actual.getRowFlushBoundary());
+ Assert.assertEquals(100, actual.getMaxRowsInMemory());
Assert.assertEquals(true, actual.isLeaveIntermediate());
Assert.assertEquals(true, actual.isCleanupOnFailure());
Assert.assertEquals(true, actual.isOverwriteFiles());
diff --git
a/server/src/main/java/org/apache/druid/segment/indexing/TuningConfig.java
b/server/src/main/java/org/apache/druid/segment/indexing/TuningConfig.java
index e3a4e1f..760494e 100644
--- a/server/src/main/java/org/apache/druid/segment/indexing/TuningConfig.java
+++ b/server/src/main/java/org/apache/druid/segment/indexing/TuningConfig.java
@@ -21,6 +21,8 @@ package org.apache.druid.segment.indexing;
import com.fasterxml.jackson.annotation.JsonSubTypes;
import com.fasterxml.jackson.annotation.JsonTypeInfo;
+import org.apache.druid.indexer.partitions.PartitionsSpec;
+import org.apache.druid.segment.IndexSpec;
import org.apache.druid.segment.incremental.AppendableIndexSpec;
import org.apache.druid.segment.incremental.OnheapIncrementalIndex;
@@ -44,6 +46,11 @@ public interface TuningConfig
AppendableIndexSpec getAppendableIndexSpec();
/**
+ * Maximum number of rows in memory before persisting to local storage
+ */
+ int getMaxRowsInMemory();
+
+ /**
* Maximum number of bytes (estimated) to store in memory before persisting
to local storage
*/
long getMaxBytesInMemory();
@@ -66,4 +73,10 @@ public interface TuningConfig
return Long.MAX_VALUE;
}
}
+
+ PartitionsSpec getPartitionsSpec();
+
+ IndexSpec getIndexSpec();
+
+ IndexSpec getIndexSpecForIntermediatePersists();
}
diff --git
a/server/src/main/java/org/apache/druid/segment/realtime/appenderator/AppenderatorConfig.java
b/server/src/main/java/org/apache/druid/segment/realtime/appenderator/AppenderatorConfig.java
index 259e58c..3fc8164 100644
---
a/server/src/main/java/org/apache/druid/segment/realtime/appenderator/AppenderatorConfig.java
+++
b/server/src/main/java/org/apache/druid/segment/realtime/appenderator/AppenderatorConfig.java
@@ -19,8 +19,6 @@
package org.apache.druid.segment.realtime.appenderator;
-import org.apache.druid.indexer.partitions.PartitionsSpec;
-import org.apache.druid.segment.IndexSpec;
import org.apache.druid.segment.indexing.TuningConfig;
import org.apache.druid.segment.writeout.SegmentWriteOutMediumFactory;
import org.joda.time.Period;
@@ -32,11 +30,6 @@ public interface AppenderatorConfig extends TuningConfig
{
boolean isReportParseExceptions();
- /**
- * Maximum number of rows in memory before persisting to local storage
- */
- int getMaxRowsInMemory();
-
int getMaxPendingPersists();
/**
@@ -57,17 +50,11 @@ public interface AppenderatorConfig extends TuningConfig
throw new UnsupportedOperationException("maxTotalRows is not
implemented.");
}
- PartitionsSpec getPartitionsSpec();
-
/**
* Period that sets frequency to persist to local storage if no other
thresholds are met
*/
Period getIntermediatePersistPeriod();
- IndexSpec getIndexSpec();
-
- IndexSpec getIndexSpecForIntermediatePersists();
-
File getBasePersistDirectory();
AppenderatorConfig withBasePersistDirectory(File basePersistDirectory);
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
